Upgrade eslint #8101
Upgrade eslint #8101
Conversation
|
The majority of the rules were fixable with eslint alone, but |
spalger
force-pushed
the
upgrade/eslint
branch
8 times, most recently
from
828490b
to
4b43cdc
Compare
| 'src', | ||
| 'tasks', | ||
| 'test', | ||
| 'utilities', |
There was a problem hiding this comment.
This array needs to be defined with the root and a globbing pattern for lint_staged_files.js to pick up the staged files:
lintThese: [
'<%= root %>/Gruntfile.js',
'<%= root %>/bin/**/*.js',
'<%= root %>/config/**/*.js',
'<%= root %>/src/**/*.js',
'<%= root %>/tasks/**/*.js',
'<%= root %>/test/**/*.js',
'<%= root %>/utilities/**/*.js',
],
There was a problem hiding this comment.
Ah, the **/*.js is necessary. Makes sense
There was a problem hiding this comment.
We can use ** instead of the root reference, too:
lintThese: [
'**/Gruntfile.js',
'**/bin/**/*.js',
'**/config/**/*.js',
'**/src/**/*.js',
'**/tasks/**/*.js',
'**/test/**/*.js',
'**/utilities/**/*.js',
],
|
This is really awesome. I found one bug, and have a few other thoughts:
|
Eh, there is less than a single page of commits. Release notes are probably overkill
Unfortunately, preventing this would require a pretty sophisticated grunt task. This limitation has existed since the pre-commit check was introduced years ago and only comes up very rarely, so I'm not convinced it's worth the effort. |
spalger
force-pushed
the
upgrade/eslint
branch
12 times, most recently
from
f4b5e12
to
9fb001c
Compare
|
LGTM |
…signments jscodeshift
spalger
force-pushed
the
upgrade/eslint
branch
from
8ed58b7
to
11eaad5
Compare
spalger
force-pushed
the
upgrade/eslint
branch
from
11eaad5
to
039cef5
Compare
|
I'm going to take another stab at this in a new pr, with a basic tool to help transform files |
Fixes #7609
Fixes #7622
Upgrades eslint and other related dependencies to the latest versions so that we can take advantage of some of the new auto-fixing features while making the transition to babel 6.
The commits are laid out to help the reviewer focus on a single change type at a time. commits mentioning "autofix" were done completely with
npm run lintrollerand do not need to be as thoroughly checked.